-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve module augmentation in table
plugin
#13568
Improve module augmentation in table
plugin
#13568
Conversation
I'm also concerned about automatic tests for other packages. Those import other features to test integrations and they probably do not import using |
My biggest doubt regarding this is: why do we have |
We decided to keep all module augmentation in a separate file (not inlined in This doesn't have to be applied in the consuming projects as long as they import everything from the main // ✔️
import { Table } from '@ckeditor/ckeditor5-table';
// ❌
import Table from '@ckeditor/ckeditor5-table/src/table'; |
|
Note: Squash all commits in this branch before the merge so to not pollute the history with all the test import changes. |
Adding When debugging this with @niegowski and comparing behavior of We need to investigate why seemingly random |
Above issue with the wrong `tsconfig.json` being loaded will be fixed in ckeditor/ckeditor5-dev#847 |
26325f6
to
66e9eb2
Compare
…module-augmentation-for-table-plugin
e368dd8
to
c073e28
Compare
Note to self: I wanted to comment that you changed formatting of JSON files and I remember that we have a special rule for them in |
02959b2
to
6166b55
Compare
351e81f
to
dd39b3c
Compare
Please update the "Suggested merge commit message" to address changes in this PR. |
…module-augmentation-for-table-plugin
2c85bd5
to
0f1b3b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But TBH, too many changes. I will depend on CI results.
84478c6
to
bd77486
Compare
Suggested merge commit message (convention)
Internal: Improve TypeScript configuration in the project and module augmentation in
table
plugin. Related to #13565.